build icon indicating copy to clipboard operation
build copied to clipboard

Published 20 hours ago • verified publisher icon netlify

Make the deploy core plugin use gRPC

Open ehmicky opened this issue 4 years ago • 3 comments

The deploy core plugin currently uses plain TCP + JSON. We should migrate it to gRPC.

It might be good to do this separately from implementing the new flow between the buildbot and Netlify Build. This would allow us to split the work and reduce the risk. This would also minimize the risk for breakage for Algolia users who currently rely on the deploy core plugin.

ehmicky avatar Jan 19 '21 13:01 ehmicky

I think this makes perfect sense as we'll be replacing the current IPC mechanism with the one we're planning to use long term.

erezrokah avatar Jan 19 '21 14:01 erezrokah

Fixed by https://github.com/netlify/build/pull/2273

ehmicky avatar Feb 15 '21 21:02 ehmicky

I'm ice boxing this for now :(

erezrokah avatar Aug 19 '21 11:08 erezrokah

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 14 days if no further activity occurs. Thanks!

github-actions[bot] avatar Mar 25 '23 14:03 github-actions[bot]

This issue was closed because it had no activity for over 1 year.

github-actions[bot] avatar Apr 08 '23 14:04 github-actions[bot]