build icon indicating copy to clipboard operation
build copied to clipboard

Add onPreInstall event

Open rvanmil opened this issue 4 years ago • 8 comments

Which problem is this feature request solving?

I was hoping to be able to use build plugins to solve our npmrc problem described and workaround over here but it doesn't seem to be possible, because the plugins are started too late in the process to do so.

Describe the solution you'd like

The onInit event launches after all dependencies are installed, so what I would need is something like an onPreInstall event which allows me to do stuff before npm/yarn install is executed.

Describe alternatives you've considered

The somewhat hacky workaround as described in the community post.

Can you submit a pull request?

Not right now but I'll be happy to submit one if this is a possibility and the way forward to implementing such an event.

rvanmil avatar Apr 15 '20 15:04 rvanmil

Hi @rvanmil,

This feature is on our roadmap. Implementing it requires some refactoring described at #1178 to be done first, which has delayed doing it. However we are looking into moving this forward. Thanks for bringing this up!

Edit: mentioned in #1353 too. Edit: mentioned in https://community.netlify.com/t/plugin-pre-install-steps/16589 too Edit: mentioned in https://community.netlify.com/t/permission-denied-cannot-modify-node-modules-folder-for-monorepo-caching/16222 too

ehmicky avatar May 25 '20 17:05 ehmicky

@ehmicky Awesome!

maru3l avatar May 25 '20 17:05 maru3l

That is great news, thanks!

rvanmil avatar May 25 '20 17:05 rvanmil

hey guys, do we have any news or ETA on this feature? Thanks.

jorgemartins-uon avatar Oct 08 '20 02:10 jorgemartins-uon

Any ETA?

Timkor avatar Nov 29 '20 10:11 Timkor

Would be very useful! My use case is to prevent installing python dependencies (rm Pipfile*). Any update on the progress of this roadmap feature?

nikolaik avatar Aug 06 '21 12:08 nikolaik

Any progress on this?

danielpoliak avatar May 09 '22 08:05 danielpoliak

Any updates on this?

rexwangcc avatar Aug 02 '22 13:08 rexwangcc

Any updates on this? Private repo installation Config for Netlify conflicts with GitHub CI

itsmnthn avatar Nov 08 '22 13:11 itsmnthn

Any progress on this?

wouter-muller avatar Dec 20 '22 13:12 wouter-muller

In case anyone is looking for a clean solution to this problem, we were able to move everything to GitHub Actions and do the build etc. over there. On Netlify the sites have been delinked from their repo's, disabling the build process of Netlify (post processing can still be done if needed). Deployment of the bundle to Netlify CDN is then done using the Netlify CLI. It may not be possible for all use cases, but for ours (building SPA's with create-react-app) it works great.

rvanmil avatar Jan 26 '23 11:01 rvanmil