build icon indicating copy to clipboard operation
build copied to clipboard

[epic] Fix log streaming

Open ehmicky opened this issue 5 years ago • 1 comments

There are several issues in the buildbot related to logs:

  • [ ] empty lines get removed: https://github.com/netlify/buildbot/issues/595
  • [x] logs get truncated: https://github.com/netlify/buildbot/issues/384
  • [ ] logs from @netlify/build and the buildbot get interleaved: https://github.com/netlify/buildbot/issues/673
  • [x] log lines get broken down to several lines: https://github.com/netlify/buildbot/issues/601
  • [x] odd error messages a the end: https://github.com/netlify/buildbot/issues/627
  • [ ] too many log messages: https://github.com/netlify/buildbot/issues/682
  • [x] bold/italic/underline do not work: https://github.com/netlify/netlify-react-ui/issues/7308

Netlify Build tries to patch this with three things that are basically hacks and that only work around few of those issues:

  • instead of streaming logs, buffer them. This negatively impacts DX since users need to wait for a Build plugin event handler to complete to see its logs (instead of seeing in real-time). This also prevents a workaround for the logs truncating issue from working (#1147).
  • wait for an additional second at the end of all builds
  • use this terrible hack (which probably does not completely work) to wait for plugins stdout/stderr to be flushed out before ending @netlify/build

We need to get a more proper support for log streaming.

ehmicky avatar Apr 13 '20 12:04 ehmicky

Marking as epic, several of these efforts are ongoing. There's definitely a lot we can do to improve logging.

mheffner avatar Apr 13 '20 15:04 mheffner

This issue has been automatically marked as stale because it has not had activity in 1 year. It will be closed in 14 days if no further activity occurs. Thanks!

github-actions[bot] avatar Oct 11 '22 14:10 github-actions[bot]

This issue was closed because it had no activity for over 1 year.

github-actions[bot] avatar Oct 25 '22 14:10 github-actions[bot]