build-image icon indicating copy to clipboard operation
build-image copied to clipboard

Published 20 hours ago • verified publisher icon netlify

feat: Update Emacs to version 28.1

Open kaushalmodi opened this issue 2 years ago • 4 comments

Fixes https://github.com/netlify/build-image/issues/782.

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #782.

This PR is necessary because I have started facing Emacs package build dependency issues when building some sites that rely on Emacs. The current default Emacs version 26.3 is more than 3 years old. This PR bumps up the Emacs version to 28.1 that got released in April 2022.

image

For us to review and ship your PR efficiently, please perform the following steps:

  • [x] Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • [x] Read the contribution guidelines 📖. This ensures your code follows our style guide and passes our tests.
  • [ ] Update or add tests (if any source code was changed or added) 🧪
  • [x] Update the included software doc (if you updated included software) 📄
  • [ ] Update or add documentation (if features were changed or added) 📝
  • [ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

image

kaushalmodi avatar Oct 07 '22 15:10 kaushalmodi

I'll need help with this PR. The build error says:

54.18 E: Unable to locate package emacs28-nox

But from https://github.com/kelleyk/ppa-emacs, I read that

You'll need to pick one of these types of packages to install.

  • emacs28: With support for X11 via GTK3. You may also want to consider trying emacs28-nativecomp.
  • emacs28-nox: Without support for X11.
  • emacs28-nativecomp: Same configuration as emacs28 but with native compilation. These packages are available for 22.04 LTS ("focal") and later.

kaushalmodi avatar Oct 07 '22 16:10 kaushalmodi

@Benaiah Can you please review this? I had to re-add ppa:kelleyk/emacs that was removed in https://github.com/netlify/build-image/commit/26189bc0a392997d49dcedcbaeac989fd8387e97 so that emacs28-nox can be installed.

kaushalmodi avatar Oct 07 '22 16:10 kaushalmodi

The CI is on hold. How to proceed?

image

kaushalmodi avatar Oct 07 '22 17:10 kaushalmodi

@kaushalmodi Currenlty we're a bit limited in bandwidth to review, merge, and release contributions.

You can install newer versions of emacs via Hombrew at the moment. See https://answers.netlify.com/t/now-in-experimental-alpha-homebrew-access-in-the-build-image/26074 for details. Keep in mind it's still in alpha, but it should unblock your use case.

kitop avatar Oct 07 '22 17:10 kitop

@kitop If you don't mind, can you please tag this PR hacktoberfest-accepted ?

kaushalmodi avatar Oct 28 '22 16:10 kaushalmodi

I'm going to close this since we don't have the bandwidth to support it and seems to be an edge case that can be worked around with Homebrew

kitop avatar Dec 06 '22 20:12 kitop