build-image icon indicating copy to clipboard operation
build-image copied to clipboard

Published 20 hours ago • verified publisher icon netlify

Customizable Java version

Open kennyjwilli opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe.

Some build tools require a particular version of Java (e.g., Google Closure Compiler). The current version of the build-image requires Java 8 and does not appear customizable. The Google Closure Compiler, for example, requires Java 11, and is therefore incompatible with Netlify (builds will fail due to the mismatched version).

Describe the solution you'd like

Add the ability to specify the Java version required in a manner similar to how it does so for other tools described here.

Describe alternatives you've considered

  1. Install Java every time the CI runs. This is a time consuming operation that would greatly increase our total build times.
  2. As suggested by a Netlify support engineer, we could include the Java version we want to use in our actual code repository, shelling out to that executable instead. This may work (?), but would bloat our repository size until the end of time.

Additional context

Can you submit a pull request?

Not at this time.

kennyjwilli avatar Jun 15 '22 00:06 kennyjwilli

I found this issue when I realized my ClojureScript builds with Shadow-Cljs were failing.

The easiest temporary workaround for me was to downgrade shadow-cljs to version 2.19.6. Version 2.19.7 introduces the dependency to Java 11+ (indirectly through a newer version of the Google Closure Compiler).

jacobemcken avatar Oct 19 '22 12:10 jacobemcken

I've looked further into this issue, because I wanted to see how hard it would be to create a PR.

DISCLAIMER: I am not Docker or Java or Linux expert, so read the following with that in mind.

According to http://packages.ubuntu.com the Debian (amd64) packages will take up the following space once installed:

Currently, the Docker "build image" takes up 2.12GB (just built it locally). In my book, that would mean that for every Java version extra installed, the build image size would increase with at least 10%.

It seems all the Java packages contain the following zip file, with the source code for the Java release It takes up a considerable amount of space on the disk (around 50Mb): /usr/lib/jvm/java-11-openjdk-amd64/lib/src.zip

Dunno, how important that file is.

Trade offs, trade offs :shrug:

jacobemcken avatar Oct 19 '22 16:10 jacobemcken