build-image icon indicating copy to clipboard operation
build-image copied to clipboard

add webm to the default fetchinclude

Open mansona opened this issue 3 years ago โ€ข 0 comments

Summary

Fixes https://github.com/netlify/build-image/issues/777

This PR adds webm files to the default fetchinclude. This means that users who are making use of LFS and have webm video files won't have issues when deploying sites ๐Ÿ‘

I struggled for about a week trying to find the exact set of levers to pull to make LFS work with my site and I came across this thread that ultimately solved the issue: https://answers.netlify.com/t/webm-not-working-under-git-hub-lfs/14460/4

My reasoning for opening this PR is that I'm assuming (possibly naively) that this can't hurt anyone's existing sites, and it just unblocks people that happen to be using LFS with webm files.


For us to review and ship your PR efficiently, please perform the following steps:

  • [x] Open a bug/issue before writing your code ๐Ÿง‘โ€๐Ÿ’ป. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire ๐Ÿ”ฅ (e.g. incident related), you can skip this step.
  • [x] Read the contribution guidelines ๐Ÿ“–. This ensures your code follows our style guide and passes our tests. ~- [ ] Update or add tests (if any source code was changed or added) ๐Ÿงช~ ~- [ ] Update the included software doc (if you updated included software) ๐Ÿ“„~ ~- [ ] Update or add documentation (if features were changed or added) ๐Ÿ“~
  • [ ] Make sure the status checks below are successful โœ…

So I have made the only check that I have control over pass ๐Ÿค” I don't know how to make the label check pass since I'm not able to label this PR ๐Ÿค”

A picture of a cute animal (not mandatory, but encouraged)

My profile pic has a cute animal in it ๐Ÿ˜‰ his name is Rodney ๐Ÿถ

mansona avatar Apr 14 '22 19:04 mansona