nextjs-blog-theme icon indicating copy to clipboard operation
nextjs-blog-theme copied to clipboard

Published 20 hours ago • verified publisher icon netlify-templates

check fix for default theme

Open tzmanics opened this issue 3 years ago • 3 comments

fix made to avoid undefined for the BLOG_THEME https://github.com/netlify-templates/nextjs-blog-theme/blob/51f6070980ee9f3e113a3d502d876cecd5ceb3be/components/wizard/RecapBar.js#L125

review fix to see how to best change.

tzmanics avatar Feb 18 '22 21:02 tzmanics

I think the better option is to use ?? rather than ||

iamaseem avatar Feb 20 '22 06:02 iamaseem

Hs

Azadina avatar Feb 21 '22 03:02 Azadina

I think the better option is to use ?? rather than ||

I think either is totally fine for this particular case, we want this to be a temporary solution.

Ideally we are able to set this default elsewhere and then build that into our deploy URL. This is all so we can make sure the wizard workflow works well for people!

maxcell avatar Feb 22 '22 14:02 maxcell