application-engine icon indicating copy to clipboard operation
application-engine copied to clipboard

[NAE-1927] Shared Roles

Open Kovy95 opened this issue 1 year ago • 1 comments

Description

  • copying of functionality from enterprise edition

Implements NAE-1927

Dependencies

none

Third party dependencies

No new dependencies were introduced

Blocking Pull requests

Depends on https://github.com/netgrif/petriflow/pull/15

How Has Been This Tested?

manually

Test Configuration

Name Tested on
OS LinuxMint
Runtime Java 11
Dependency Manager Maven 3.8.4
Framework version SpringBoot 2.6.2
Run parameters
Other configuration

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] My changes have been checked, personally or remotely, with @...
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have resolved all conflicts with the target branch of the PR
  • [ ] I have updated and synced my code with the target branch
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing tests pass locally with my changes:
    • [ ] Lint test
    • [ ] Unit tests
    • [ ] Integration tests
  • [ ] I have checked my contribution with code analysis tools:
  • [ ] I have made corresponding changes to the documentation:
    • [ ] Developer documentation
    • [ ] User Guides
    • [ ] Migration Guides

Kovy95 avatar Feb 21 '24 15:02 Kovy95

This PR has 96 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +77 -19
Percentile : 38.4%

Total files changed: 5

Change summary by file extension:
.md : +36 -0
.java : +41 -19

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

:tada: All dependencies have been resolved !

dpulls[bot] avatar Sep 12 '24 12:09 dpulls[bot]