Fixed issue when clicking the preview button from the node view full template would cause errors due to form token

[thiagocamposviana]

Fixed issue when clicking the preview button from the node view full template would cause errors due to form token

[emodric]

Hm... Are you sure this is the right fix? What if the ezxformtoken extension is installed? As far as I know, that extension rewrites any POST submit to check for ezxform_token variable.

Also, I haven't ran into this issue before. Can you detail steps to reproduce this?

Thanks!

[thiagocamposviana]

Tested this in ezp 2.3 after the changes submitted by Philipp to get back the "Preview" button at the top in the node view full view. If you click the button there is going to appear some errors related to the form token and also related to the language.

See:

https://github.com/netgen/NetgenAdminUIBundle/commit/bf0c1ca521f8577199f3bda1cf3968abe1058306

Also: https://github.com/netgen/NetgenAdminUIBundle/commit/48de5858a99167c3da5055963bf101e0c95fd91b

and https://github.com/netgen/NetgenAdminUIBundle/commit/c9a4445f6da86de0aa59decdaa63b43ed6b716d9

[emodric]

I still cannot reproduce this. Clicking the Preview button at the top of the full view takes me to the preview without issues.

[thiagocamposviana]

@emodric What is the base ezp + legacy version you are using?

[emodric]

@thiagocamposviana eZ Platform 2.4.0 and eZ Publish Legacy 2018.09.2

[thiagocamposviana]

Alright, I will try to reproduce and record this sometime next week and I will post the video here. I have just installed eZP 2.4 yesterday and I am sure the form token extension is checking for "_token" instead of "ezxform_token" with legacy bridge.

[emodric]

Alright, I've reproduced the issue, some caches were probably to blame :-o

Anyways, as far as I can see, there are multiple places where ezxform_token POST variable is being used in Netgen Admin UI, would you update all of them in this PR, so we can fix them all at once?

[thiagocamposviana]

Looks like a good idea.

[andrerom]

Maybe we should make this configurable and let legacy bridge set ezxformtoken to use the Symfony convention? That is the approach used for more other things around tis.

[emodric]

@andrerom For Netgen Admin UI, it doesn't need to be configurable, I think, since it cannot be used in pure legacy context. But as an idea it's good for ezpublish-legacy with legacy bridge.

[andrerom]

But as an idea it's good for ezpublish-legacy with legacy bridge.

This is the context I'm talking about, but yes should have made the comment on the other PR and pinged you ;)

[emodric]

What do you think @thiagocamposviana ?

[thiagocamposviana]

It should be an enhancement, as of right now it as long this is a bug, the present solution solves the bug without allowing any configuration, which is ok to certain extent, the enhancement would be good as a future step but not mandatory atm as long it might take way longer to review and approve and we require a solution for the bug itself not necessary containing the enhancement.

[andrerom]

True, but this one: https://github.com/ezsystems/ezpublish-legacy/pull/1420

is not clean.

So you kind of need the injection => to handle this cleanly => to be able to get this merged => in order to solve the bug.

Right? ;)

[thiagocamposviana]

Alright, as long that affects only a php file I think I can make the token identifier configurable easily.