suzieq icon indicating copy to clipboard operation
suzieq copied to clipboard

Add support for SSH certificate file in Node class

Open rnwolfe opened this issue 10 months ago • 2 comments

i will fill this out further, but wanted to open PR for viewing outside of myself

Test inclusion requirements

In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:

  • any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
  • a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
  • any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir

For additional information about tests, follow this link

Related Issue

Fixes #972

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

Adds support for cert-based ssh auth

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Comments

Include additional comments about the this pull request

Double Check

  • [x] I have read the comments and followed the CONTRIBUTING.md.
  • [x] I have explained my PR according to the information in the comments or in a linked issue.
  • [x] My PR source branch is created from the develop branch.
  • [x] My PR targets the develop branch.
  • [ ] All my commits have --signoff applied

rnwolfe avatar Jan 30 '25 22:01 rnwolfe

I had rebased my PR on top of #974, so may need to do some git-fu here before merge.

The latest change in https://github.com/rnwolfe/suzieq/commit/6922031bc2db5129db8033ddb74c39a95ac96612 does fix by removing pvt key handling and offloading that to the asyncssh logic which handles it more robustly.

This worked in my environment with ~9 cert-based auth linux nodes.

rnwolfe avatar Jan 31 '25 20:01 rnwolfe

I ran pytest signed my last commit, but with the other commits I pulled in, I couldn't sign my prior one. I also now added multiple versions of myself to the history. Whoops!

Let me know if I should do anything clean this up.

rnwolfe avatar Feb 03 '25 16:02 rnwolfe