David P. Baker comments

Results 135 comments of


                                            David P. Baker

Add a `constrain` method to Range.

We should focus on the requirements and the API before writing the implementation.

Fix typos in Javadocs, comments and code

I'm going to take a look at this. I'm more interested in the typos and other errors, and not so much in the formatting (some of which is an artifact...

Cache's computeIfPresent discards if error'd entry

Thanks! Do you have a fix in mind? We would test and accept a PR.

"finally" for futures

This makes me think that we should change `ClosingFuture` to guarantee that closing doesn't start until the future is really done, meaning on cancelation it would wait for any running...

stopTimers capture in ServiceManager

Hi @ayushjais2654. Thanks for this work, but we have to make a decision on whether we want to suppor this feature (#5842) in Guava before we can merge an implementation....

Provide ServiceManager.stopTimes() to enable debugging slow ServiceManager shutdowns

Do you actually have a use case for this feature? What will you use it for? Or are you proposing it simply for completeness?

Instant.until(Instant, DateTimeUnit.TimeBased) and until(Instant, DateTimeUnit, TimeZone) maybe shouldn't be overloads

I think the behavior is well-defined, but the worry is that it's easy to mistake one for the other. In fact, if you're implementing `until(Instant, DateTimeUnit, TimeZone)` to _ignore_ the...

Instant.until(Instant, DateTimeUnit.TimeBased) and until(Instant, DateTimeUnit, TimeZone) maybe shouldn't be overloads

> > it's easy to mistake one for the other > > Could you elaborate on this? If the client code operates on a unit that's known to be time-based,...

Better documentation of advantages of Flogger compared to JDK and other logging APIs

There's documentation of this here: https://google.github.io/flogger/benefits

package locations, e.g. `@Implies`

A slight advantage to having a subpackage per domain: each subpackage can have Javadoc in its `package-info.java` file.