netdata icon indicating copy to clipboard operation
netdata copied to clipboard

Published 20 hours ago • verified publisher icon netdata

[Bug]: netdatacli limits the message size

Open underhood opened this issue 2 years ago • 10 comments

Bug description

netdatacli has limit for output size of 4096

Expected behavior

do we just increase this limit or make it transfer arbitrary message sizes?

underhood avatar Mar 14 '22 12:03 underhood

I would vote for arbitrary message sizes, we should be future-proofing this if at all possible.

Ferroin avatar Mar 14 '22 12:03 Ferroin

I would vote for arbitrary message sizes, we should be future-proofing this if at all possible.

yep I strongly prefer that

underhood avatar Mar 16 '22 21:03 underhood

@underhood what is the latest status on this?

cpipilas avatar Jun 29 '22 11:06 cpipilas

@cpipilas this is a relatively small issue, it was not picked up due to work on what I perceive to be higher prio. things (now for example fixing the mqtt5 problem from yesterday)

it is just a matter of planning, also a good beginner-friendly issue (added label "good first issue", not sure that is still used by anybody) as any C-dev should be able to handle it after playing a bit with libuv.

underhood avatar Jun 30 '22 06:06 underhood

In general, it is problem only for bigger parents and netdatacli aclk-state command which is to my knowledge the only one which can produce longer output (and only in case there are a lot of children). This same data can be received also by /api/v1/aclk-state endpoint.

For those reasons, I consider it a low priority.

underhood avatar Jun 30 '22 06:06 underhood

@underhood Is there anyone working on this issue？If not，may I have a try？

ckcckk avatar Feb 15 '23 09:02 ckcckk

@ckcckk Hi, i have it on my backlog but have not yet got to it (did just short look at it and then was interrupted by higher prio stuff). Currently working on the h2o webserver integration. Sure you can have a go at it :)

underhood avatar Feb 25 '23 03:02 underhood

@underhood Thanks for your reply, I will deal with this issue next.

ckcckk avatar Feb 26 '23 07:02 ckcckk

Hey @underhood, I am new to the project and if the issue is still not resolved I would really like to give it a go to actually start my open-source journey. Can you assign the to me?

deekshithpranav avatar Mar 17 '23 08:03 deekshithpranav

@deekshithpranav as this is opensource project we of course welcome everyone to contribute with joy. This issue indeed is a good starting issue. Only thing that comes to my mind is that @ckcckk above expressed interest in solving it. However we didn't hear back from him after the message you see here. So I am not sure if he is working on it or made any progress.

underhood avatar Mar 21 '23 10:03 underhood

I would vote for arbitrary message sizes, we should be future-proofing this if at all possible.

By future-proofing, would getting the system limits like max argument size be a solution?

jphwang212 avatar Oct 26 '23 22:10 jphwang212