skele icon indicating copy to clipboard operation
skele copied to clipboard

Update registry doesn't use canonical

Open vule-rng opened this issue 7 years ago • 4 comments

As the title says, update registry/get are handled differently than element registry/get. I am not completely sure what are the consequences of not using canonical on updates.

vule-rng avatar Mar 03 '17 07:03 vule-rng

I think we do have a problem here. Most probably only for local updates. I think the problem is the following place: https://github.com/netceteragroup/girders-elements/blob/master/src/update/reducer.js#L62

It should have similar logic, like in the global updates here: https://github.com/netceteragroup/girders-elements/blob/master/src/update/reducer.js#L42 where the problem should not exist.

I'm happy to accept PR for this :)

andon avatar Mar 06 '17 20:03 andon

@vule-rng Could you check if this is still an issue with alpha.9 and above?

ognen avatar Oct 05 '17 10:10 ognen

@ognen I'll give it a shot.

vule-rng avatar Oct 05 '17 13:10 vule-rng

I don't think it's still an issue, but you refactored almost everything so it's a bit difficult to notice. Maybe you should extend the update tests to support this case too: registry.get( ActionRegistry.keyFor(['article', 'specific', 'something-not-registered'], 'ACTION_BLAH') )

vule-rng avatar Oct 11 '17 08:10 vule-rng