netbox icon indicating copy to clipboard operation
netbox copied to clipboard

re-enable markdown in custom columns

Open chcon opened this issue 3 years ago • 2 comments

Fixes: #9979

Introduced a new column class CustomFieldMarkdownColumn that combines the default markdown rendering behavior of the MarkdownColumn with the custom column specific constructor parameters of the CustomFieldColumn. That way markdown in custom columns should be both XSS safe and functional.

chcon avatar Aug 11 '22 13:08 chcon

Thanks for taking this on @chcon. We should be able to avoid introducing a second column class specifically for Markdown support if we can just adjust the rendering logic for longtext-type fields in the existing class.

jeremystretch avatar Aug 12 '22 14:08 jeremystretch

@jeremystretch agreed, please check it again.

chcon avatar Aug 13 '22 12:08 chcon