netbox icon indicating copy to clipboard operation
netbox copied to clipboard

Add Location to Circuit Termination

Open gjvc opened this issue 3 years ago • 7 comments

NetBox version

v3.2.5

Feature type

Data model extension

Proposed functionality

When editing a circuit termination, i can specify "Region", "Site group", and "Site", but not "Location".

I would like to specify the "Location" field (optionally) as part of the termination.

Use case

We have cross-connects between our cage and cages of other tenants in Equinix. Each tenant's cage is identified by placing the Equinix cage ID in the "Location" field, and this works well in the "Region / Site Group / Site / Location" containment hierarchy.

Right now I am having to specify the tenant's cage as the "Site", because "Location" is not available to me when editing the circuit termination, which makes for something of an impedance mismatch.

Database changes

add foreign key from CircuitTerminations to Location, (where null=True)

External dependencies

None

gjvc avatar Jun 24 '22 12:06 gjvc

basic diff (no migration or PR yet etc) here https://github.com/netbox-community/netbox/compare/develop...gjvc:9604-add-location-to-circuittermination for clarity / discussion.

  • added location field to ProviderForm
  • added location foreign key to CircuitTermination
  • added location field to circuittermination_edit.html template
  • updated circuits table to display Side A/B value via this logic: - if location is set, show location - if site only is set, show site (as before) - if provider_network only is set, show provider_network (as before)

gjvc avatar Jun 25 '22 21:06 gjvc

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

github-actions[bot] avatar Sep 12 '22 04:09 github-actions[bot]

As a service provider trying to get better PoP records for interconnects, etc., I think this could help. @gjvc do you think you can complete your code as a PR in the near future?

eronlloyd avatar Sep 13 '22 02:09 eronlloyd

@eronlloyd Certainly can! I will make a diff against develop this week and create a PR. Thank you for your consideration. :-)

gjvc avatar Sep 14 '22 11:09 gjvc

@jeremystretch would you be able to provide a milestone for this?

gjvc avatar Dec 01 '22 11:12 gjvc

This would be very handy for us as well. For us Sites is more of a 'compound' large area. Whereas Locations is down to the building within that area. And multiple circuits could come into different buildings.

GoldyXXD avatar Jul 21 '23 04:07 GoldyXXD

I agree with @GoldyXXD, we have sites with multiple demarcs and this would be really helpful.

lorsung avatar Jul 18 '24 00:07 lorsung