netbox icon indicating copy to clipboard operation
netbox copied to clipboard

Strings missing translation support

Open click0 opened this issue 1 year ago • 13 comments

Deployment Type

NetBox Cloud

NetBox Version

v4.1.2

Python Version

3.10

Steps to Reproduce

  1. According to the demo version of netbox (NetBox Community v4.1.2), not all translated strings are displayed For example, Markdown syntax is supported Screenshot 2024-09-28 at 00-45-37 Редагування бездротова локальна мережа ьн_ашкые_ЫЫШВ NetBox

  2. Similar here, translation strings. Screenshot 2024-09-28 at 00-53-39 Data Sources NetBox

Expected Behavior

I expect correct transfer of translated strings from the transifex.com service to the repository Netbox on GitHub.

Observed Behavior

Apparently, not all translated strings were transferred to the repository. Or demo.Netbox receives translation strings differently.

click0 avatar Sep 30 '24 12:09 click0

@click0 which page are you seeing the "Markdown syntax is supported" on? There is a translated string for this (https://github.com/netbox-community/netbox/blob/develop/netbox/utilities/forms/fields/fields.py#L30) so I need to check against that specific page.

arthanson avatar Oct 02 '24 14:10 arthanson

@click0 which page are you seeing the "Markdown syntax is supported" on? There is a translated string for this (https://github.com/netbox-community/netbox/blob/develop/netbox/utilities/forms/fields/fields.py#L30) so I need to check against that specific page.

Yes, it looks like it.

<span class="form-text"><i class="mdi mdi-information-outline"></i> <a href="[/static/docs/reference/markdown/](view-source:https://demo.netbox.dev/static/docs/reference/markdown/)" target="_blank" tabindex="-1">Markdown</a> syntax is supported</span>

click0 avatar Oct 02 '24 16:10 click0

Yes, it looks like it.

Aurthur is asking for the URL that you are visiting. He needs to check the form and the template files to ensure they are translation enabled

DanSheps avatar Oct 02 '24 17:10 DanSheps

so I need to check against that specific page.

Based on lens, I think this is "Wireless LANs".

Looks like utilities.forms.fields.fields.CommentField has translation enabled for help_text but because it includes HTML tags it likely isn't getting translated properly

DanSheps avatar Oct 02 '24 17:10 DanSheps

Aurthur is asking for the URL that you are visiting. He needs to check the form and the template files to ensure they are translation enabled

https://demo.netbox.dev/wireless/wireless-lans/1/edit/

click0 avatar Oct 02 '24 17:10 click0

One more place Screenshot 2024-10-02 at 20-19-18 Додати новий спрацьовує правило NetBox

click0 avatar Oct 02 '24 17:10 click0

Thanks

DanSheps avatar Oct 02 '24 17:10 DanSheps

One more location.

Screenshot 2024-11-06 at 17-41-12 Jobs NetBox

click0 avatar Oct 02 '24 17:10 click0

Also, in some places the first and second words of the phrase suddenly start with a capital symbol. or open a new issue?

click0 avatar Oct 02 '24 17:10 click0

Also, in some places the first and second words of the phrase suddenly start with a capital symbol. or open a new issue?

If it is specific to the Russian Language, I would look at our Transifex and see if you can help improve it.

The ones you have posted so far are definintely all global issues and not specific to the language itself.

DanSheps avatar Oct 02 '24 19:10 DanSheps

If it is specific to the Russian Language, I would look at our Transifex and see if you can help improve it.

I checked this page in Russian and Dutch translations - yes, there is a capital first character of the second word of the phrase.

Screenshot 2024-10-02 at 22-51-20 Virtuele Machines NetBox

The ones you have posted so far are definintely all global issues and not specific to the language itself.

There could also be an error transferring the translation to demo.netbox.dev. I don't see the pipeline of this process.

click0 avatar Oct 02 '24 19:10 click0

I found another location with unadded strings for translation.

Screenshot 2024-10-07 at 03-27-13 dmi01-akron-rtr01 NetBox

Screenshot 2024-10-07 at 03-25-15 dmi01-akron-rtr01 NetBox

click0 avatar Oct 07 '24 00:10 click0

And one more location.

Edit2

click0 avatar Oct 07 '24 00:10 click0

And one more location. Screenshot 2024-10-29 at 03-47-24 Жетонів NetBox

click0 avatar Nov 05 '24 23:11 click0

And one more location. In the "Slug" field, enter non-latin characters and click the "Create" button. Screenshot 2024-10-29 at 03-38-20 Додати новий група каналу зв'язку NetBox

click0 avatar Nov 05 '24 23:11 click0

And one more location.

Screenshot 2024-10-29 at 03-34-42 Додати новий Призначення групи каналів зв'язку NetBox

click0 avatar Nov 05 '24 23:11 click0

And one more location. Screenshot 2024-11-06 at 01-46-41 Мітки NetBox

click0 avatar Nov 05 '24 23:11 click0

Thanks for all the information. Definintely helpful.

I am not 100% sure how we can translate the strings for the model names, I am sure one of the other maintainers will chime in.

DanSheps avatar Nov 06 '24 14:11 DanSheps

I found another location with unadded strings for translation.

Screenshot 2024-10-07 at 03-27-13 dmi01-akron-rtr01 NetBox

Screenshot 2024-10-07 at 03-25-15 dmi01-akron-rtr01 NetBox

Here, buttons "Edit selected" and "Rename" remain untranslated.

click0 avatar Nov 06 '24 15:11 click0

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. NetBox is governed by a small group of core maintainers which means not all opened issues may receive direct feedback. Do not attempt to circumvent this process by "bumping" the issue; doing so will result in its immediate closure and you may be barred from participating in any future discussions. Please see our contributing guide.

github-actions[bot] avatar Apr 24 '25 04:04 github-actions[bot]

This issue has been automatically closed due to lack of activity. In an effort to reduce noise, please do not comment any further. Note that the core maintainers may elect to reopen this issue at a later date if deemed necessary.

github-actions[bot] avatar May 26 '25 04:05 github-actions[bot]