netbox icon indicating copy to clipboard operation
netbox copied to clipboard

Allow for custom names for Identity Provider text in the Login link

Open vmorris opened this issue 1 year ago • 3 comments

NetBox version

v3.7.3

Feature type

Change to existing functionality

Proposed functionality

Recently oidc was added to the auth backend (https://github.com/netbox-community/netbox/issues/14587) to make the login link more user friendly.

In the issue, @llamafilm also requested the ability to customize this text, as there are many different OIDC IdP. (https://github.com/netbox-community/netbox/issues/14587#issuecomment-1877804701)

This request is to add that functionality to specify a custom name in the login link for any social login provider.

Use case

There are many different social IdPs and users will appreciate knowing which one they are going to be authenticating to.

Database changes

None

External dependencies

None

vmorris avatar Mar 08 '24 02:03 vmorris

IMHO this shouldn't be exclusive to OIDC. Defining a custom name for other social auth types like KeyCloak or SAML would be good, too.

alehaa avatar Mar 08 '24 22:03 alehaa

Agreed. @vmorris Can you edit this request to make it generic? I have a patch already, I can make a PR.

llamafilm avatar Mar 09 '24 04:03 llamafilm

@llamafilm okay, updated, thanks!

vmorris avatar Mar 10 '24 13:03 vmorris