netbox-floorplan-plugin icon indicating copy to clipboard operation
netbox-floorplan-plugin copied to clipboard

Support for Netbox 4.0.11 and 4.1.0

Open bogi788 opened this issue 1 year ago • 10 comments

Both Netbox 4.0.11 and 4.1.0 have been released this week. The floorplan raises an ImproperlyConfigured exception on both because the maximum version was set to 4.0.10 in https://github.com/netbox-community/netbox-floorplan-plugin/commit/fadfe4428c95654a665f5123e4575bd9152361f6.

bogi788 avatar Sep 04 '24 07:09 bogi788

Hello, I got same issue, the problem is that the plugin does not support version 4.1.0 (the maximum supported version is 4.0.10), please consider fixing this

FromNetToDev avatar Sep 05 '24 11:09 FromNetToDev

pinning on the patch-level is wrong IMO. There should not be any breakage on patch releases, so this only causes unnecessary delays until a new floorplan release is cut.

uedvt359 avatar Sep 11 '24 09:09 uedvt359

we have already version 4.1.1....

darkfritz2 avatar Sep 17 '24 18:09 darkfritz2

Yes because of this i can not use this plugin it throw that the maximum netbox is 4.0.10 but i have 4.1.0

Zheer09 avatar Sep 18 '24 07:09 Zheer09

Any update on this? is there any other changes that are needed to make the plugin compatible with Netbox 4.1.x aside from just updating the max version in the setup.py file?

brandan-schmitz avatar Sep 24 '24 18:09 brandan-schmitz

In the meantime, you can apply the following to get this running, although I am not sure it is functioning correctly:

  1. Install the floorplan plugin as normal
  2. Modify the max_version in /opt/netbox-X.Y.Z/venv/lib/python3.11/site-packages/netbox_floorplan/__init__.py, replacing X.Y.Z with your version.
  3. cd /opt/netbox
  4. sudo ./venv/bin/python3 netbox/manage.py makemigrations netbox_floorplan_plugin
  5. sudo ./venv/bin/python3 netbox/manage.py migrate
  6. sudo ./venv/bin/python3 netbox/manage.py collectstatic --no-input
  7. sudo systemctl restart netbox netbox-rq

ZachHoiberg avatar Oct 03 '24 18:10 ZachHoiberg

this is not the "way" but seems to be working...

edit: it's working to install but the module doesnt work. you can't edit anything. set dimensions or stuff like that... so this module doesn't work.

darkfritz2 avatar Oct 04 '24 15:10 darkfritz2

Hello, 0.4.1 will support 4.0.11, 0.5.0 will support 4.1 - should be coming next few days

cruse1977 avatar Oct 10 '24 10:10 cruse1977

great to hear, @cruse1977! but please, please, please don't pin the netbox version on the patch level. most of us would rather risk it partially breaking at runtime, rather than refusing to start up at all.

afaik, the netbox team only introduces breaking changes at the minor level (i.e, y in x.y.z), but never the patch level (i.e, z in x.y.z).

uedvt359 avatar Oct 10 '24 10:10 uedvt359

great to hear, @cruse1977! but please, please, please don't pin the netbox version on the patch level. most of us would rather risk it partially breaking at runtime, rather than refusing to start up at all.

afaik, the netbox team only introduces breaking changes at the minor level (i.e, y in x.y.z), but never the patch level (i.e, z in x.y.z).

I agree. That NetBox team are good folks ;)

cruse1977 avatar Oct 10 '24 10:10 cruse1977

Hello, 0.4.1 will support 4.0.11, 0.5.0 will support 4.1 - should be coming next few days

Hi Chris, any news on a 0.5.0 version supporting NetBox 4.1.x ? I'm really eager to bring this back into my datacenter. Thanks for this great plugin 🥇

tfboy avatar Oct 25 '24 08:10 tfboy

Any update for supporting netbox 4.1?

Zheer09 avatar Nov 13 '24 20:11 Zheer09

Hello, 0.4.1 will support 4.0.11, 0.5.0 will support 4.1 - should be coming next few days

Hello. Any news about 0.5.0 release?

dmeshalkin avatar Nov 20 '24 08:11 dmeshalkin

Hi, is there any way we can help you to have the 0.5.0 release ?

atmaniak avatar Dec 08 '24 09:12 atmaniak

Doing final testing now - and looking to merge in some community PR's along the way - hopefully next few days

cruse1977 avatar Dec 08 '24 15:12 cruse1977