netbox-docker icon indicating copy to clipboard operation
netbox-docker copied to clipboard

Published 20 hours ago • verified publisher icon netbox-community

parent optional assoc in tenant_groups

Open aletessier opened this issue 3 years ago • 2 comments

Related Issue:

New Behavior

parent support tenant_groups initializer

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Wiki

maybe update the tenant_groups.yml example in comments ?

Proposed Release Note Entry

...

Double Check

  • [x] I have read the comments and followed the PR template.
  • [ ] I have explained my PR according to the information in the comments.
  • [ ] My PR targets the develop branch.

aletessier avatar Dec 30 '21 14:12 aletessier

Thank you for your PR and sorry that it took so long for one of us the comment!

maybe update the tenant_groups.yml example in comments ?

That would be great. It also serves as test, because the ./test.sh uncomments all the yamls and tries to import them. This way we're certain that the initializer scripts always work. (And we know which ones break in case upstream NetBox changes some of the internals.)

To run the tests on your local machine, perhaps have a look at my comment here: https://github.com/netbox-community/netbox-docker/pull/691#issuecomment-1028079665

cimnine avatar Feb 03 '22 16:02 cimnine

You should change the target branch to develop for this PR.

tobiasge avatar Feb 03 '22 16:02 tobiasge

Initializers are now in a plugin.

tobiasge avatar Sep 01 '22 06:09 tobiasge