netbox-bgp icon indicating copy to clipboard operation
netbox-bgp copied to clipboard

NetBox 3.3.0 Support

Open ryanmerolle opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. NetBox 3.3.0 Support & supported matrix updated.

Describe the solution you'd like NetBox 3.3.0 Support & supported matrix updated.

ryanmerolle avatar Aug 19 '22 13:08 ryanmerolle

Netbox API changed little bit in 3.3.0, until proper fix relesed it is possible to manually patch to not lose netbox-bgp in 3.3.0 with patch like this:

diff --git a/netbox_bgp/__init__.py b/netbox_bgp/__init__.py                                                      
index 7cf922c..ce613af 100644                                                                                     
--- a/netbox_bgp/__init__.py                                                                                      
+++ b/netbox_bgp/__init__.py                                                                                      
@@ -11,8 +11,8 @@ class BGPConfig(PluginConfig):                                                                  
     author_email = '[email protected]'                                                                         
     base_url = 'bgp'                                                                                             
     required_settings = []                                                                                       
-    min_version = '3.2.0'                                                                                        
-    max_version = '3.2.99'                                                                                       
+    min_version = '3.3.0'                                                                                        
+    max_version = '3.3.99'                                                                                       
     default_settings = {                                                                                         
         'device_ext_page': 'right',                                                                              
         'asdot': False                                                                                           
diff --git a/netbox_bgp/api/serializers.py b/netbox_bgp/api/serializers.py                                        
index 9cc7a0a..c002c56 100644                                                                                     
--- a/netbox_bgp/api/serializers.py                                                                               
+++ b/netbox_bgp/api/serializers.py                                                                               
@@ -1,8 +1,8 @@                                                                                                   
 from rest_framework.serializers import Serializer, HyperlinkedIdentityField, ValidationError                     
 from rest_framework.relations import PrimaryKeyRelatedField                                                      
                                                                                                                  
-from netbox.api import ChoiceField, WritableNestedSerializer, ValidatedModelSerializer                           
-from netbox.api.serializers import NetBoxModelSerializer                                                         
+from netbox.api.fields import ChoiceField                                                                        
+from netbox.api.serializers import NetBoxModelSerializer, WritableNestedSerializer, ValidatedModelSerializer     
 from dcim.api.nested_serializers import NestedSiteSerializer, NestedDeviceSerializer                             
 from tenancy.api.nested_serializers import NestedTenantSerializer                                                
 from extras.api.nested_serializers import NestedTagSerializer                                                    
--                                                                                                                
2.35.3

zombah avatar Aug 20 '22 13:08 zombah

Waiting for proper fix of this as well, when it will be uploaded to pip.

mariokamenjak avatar Sep 11 '22 18:09 mariokamenjak

This is working in my local dev instance now:

Bildschirmfoto vom 2022-09-20 10-08-51

Thank you for this!

jwbensley avatar Sep 20 '22 08:09 jwbensley