#129 add community requested source and destination objects

[rvveber]

Pull Request

Related Issue

closes #129

New Behavior

This Merge Request, enables to specify various new Source Entities for the Standard and Extended ACL Rules. It additionally enables to specify the same Entities as a Destination for the Extended ACL Rule. The new selectable entities are all from the IPAM model group:

• IP-Range
• IP-Address
• Aggregate
• Service

I have built in constraints and validation to prevent assigning more than one source/destination. Therefore adding community requested entities, while keeping the functionality the same. No changes to the API, except these newly added fields: source_iprange, source_ipaddress, source_aggregate, source_service and destination_iprange, destination_ipaddress, destination_aggregate, destination_service ...

Contrast to Current Behavior

Previously you could only assign a Prefix as Source and Destination. Now you can assign a Prefix, an IP-Range, an IP-Address, an Aggregate or a Service. ...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

Added requested models for selection as source/destination: IP-Range, IP-Address, Aggregate, Service. ...

Double Check

• [x] I have explained my PR according to the information in the comments or in a linked issue.
• [x] My PR targets the dev branch.

[cruse1977]

Hi @rvveber - thanks for this, can I ask you take a look at https://netboxlabs.com/docs/netbox/en/stable/plugins/development/migration-v4/ - note the changes to serializers (hence this in conflict currently)

[rvveber]

Hi @rvveber - thanks for this, can I ask you take a look at https://netboxlabs.com/docs/netbox/en/stable/plugins/development/migration-v4/ - note the changes to serializers (hence this in conflict currently)

Yes, i will look at it tomorrow!

[rvveber]

@cruse1977 i rebased onto the new version and updated my commits to solve the conflicts. After a quick test everything seems to be working as before. You can review

[rvveber]

@cruse1977 bump

[Mailstorm-ctrl]

Any update on this? I've bene looking forward to this feature for quite sometime.

[cruse1977]

Hi @rvveber just wanted you to know this isn't forgotten about - however its a big change. I've merged this into a forked copy of the latest dev to review - looks good so far.

[mrrtfm]

Hi @rvveber just wanted you to know this isn't forgotten about - however its a big change. I've merged this into a forked copy of the latest dev to review - looks good so far.

Yaay, looking forward to this, thanks to all the contributors!

[alexis-UE]

Hi @rvveber and @cruse1977 great feature very much needed ! Thanks a lot for the work !!! Can we merge this one ? Do you need any help on resolving conflicts or something ?

[alexis-UE]

Hi guys @rvveber @cruse1977, I rebase this PR from the latest version of the dev branch and opened this new PR: https://github.com/netbox-community/netbox-acls/pull/236 Are you OK to merge it ?

[rvveber]

@alexis-UE The rebase isn't the issue. https://github.com/netbox-community/netbox-acls/issues/129#issuecomment-2591053975 is the issue (if we listen to him). I don't have the time to re-implement the feature with dynamic assignments.