devicetype-library
devicetype-library copied to clipboard
Update PowerEdge_R740.yaml
adding the following updates:
- power supply w/ max draw
- device-bays:
- iDRAC9
- console-ports
- console-server-ports:
adding PowerEdge_R740
The console ports/console server ports also look weird, honestly.
@DanSheps really made me think. Coming from a serial console world, I had always been cut and dry what a console port was. It is a serial management port for a device. Saying a VGA port is a console port sounds crazy, but technically it is hooked to a console type of device. Confusing since both devices are completely different.
Are you going to model each keyboard, monitor plugged in? If not, it might be best to omit them as they aren't what most people would consider a console for this purpose. Keep in mind, to properly model this, you would need to have 3 links otherwise it is kind of pointless.
That said, I would like to see what other people do, or perhaps it might be best to just omit them and then let the end-user of the device-type library edit the device-type after the fact.
I guess where I am coming from is, while VGA is a console, USB in the front and back aren't really a console or a console server. It is a universal interface and those ports were mainly added to the model itself to allow for network devices with USB consoles (Catalyst Switches), which if you look back at the issue (https://github.com/netbox-community/netbox/issues/1865) that implemented it, you can see they were meant for USB-to-Serial connections, not USB to HID connections, which means those USB serial/console ports are out of scope of what was meant to be tracked.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.
Hello!, Any update on this?
@bbrk364 Hello, we have recently fixed a handful of formatting issues. In doing so it looks like your PR is out of sync. In order to fix this, please do the following:
- Sync your forks master branch with the upstream
git fetch upstream
git checkout master
git merge upstream/master
- Checkout your branch again
git checkout BRANCH_NAME
where BRANCH_NAME is the name of your branch - Merge master into your branch
git merge master
- Fix any conflicts or issues found
- Stage the changes
git add --all
- Run pre-commit scripts
pre-commit run
- Commit and push your changes
We are sorry for the inconvenience but it was a nessecary step. Thank you!
Hello @bbrk364 I am closing this as it has been 3 weeks without any progress. It still currently has a conflicts with the master branch,
If you would like to still make a contribution, please reopen this PR and fix the issue, or open a new PR on a new branch after syncing your master with the upstream.