tftpmenu not loaded if tftp filename has a path component

[abh]

I load ipxe over tftp from a path (ipxe/netboot.xyz.kpxe). If I'm not mistaken (which is very possible) that's what makes this line from netboot.xyz.j2 not match:

isset ${tftp-server} && iseq ${filename} {{ bootloader_filename }}.kpxe && goto tftpmenu ||

It's not clear to me what the iseq part is supposed to be accomplishing. I am guessing there are some filenames that shouldn't go to tftpmenu, but if so I'd suggest those should be called out rather than the opposite. (And if they shouldn't be going to tftpmenu, would they ever be running in a context with tftp-server set?).

I believe this section should be replaced with just a line like:

isset ${tftp-server} && goto tftpmenu || goto menu

(at least for my use case this fixed it so I can use MAC-[mac-address].ipxe).

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[abh]

I don't have additional information, but the issue was real.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[abh]

@antonym, am I misunderstanding how the code is supposed to work?

[kfsone]

I think there's something missing in the self-hosting instructions. I think all the images are actually supposed to be in a single directory on the tftp server? At which point, I'm not sure what the web service is for... And it seems like docker networking has changed so that using the docker container no-longer has any value, it can't open a connection back for responses.

[kfsone]

In the docker container, all of the images are in one folder.