netboot.xyz
netboot.xyz copied to clipboard
Use bootloader_filename instead of site_name for bootloader filenames consistently
Fixes #1095
I didn't change the template for the checksum file as that using site_name seemed like it might be intentionally different.
For these files the filename generated was already using bootloader_filename and the references I changed were to match the actual files.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Uh, not sure what's expected here. Bad bot?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
ping @antonym
I've tried this patch and the following is an example diff in the outputted index.html:
<tr>
<td> DHCP-snponly </td>
- <td> <a href="ipxe/netboot.chicago.inthemainfra.me-snponly.efi">netboot.chicago.inthemainfra.me-snponly.efi</a> </td>
+ <td> <a href="ipxe/netboot.xyz-snponly.efi">netboot.xyz-snponly.efi</a> </td>
<td> EFI w/ Simple Network Protocol, only boots from device chained from </td>
</tr>
which matches the contents of the ipxe/ directory correctly:
(netboot.xyz) nyang@omada:~/src/netboot.xyz$ ls buildout/ipxe/
netboot.chicago.inthemainfra.me-sha256-checksums.txt netboot.xyz.dsk netboot.xyz.efi netboot.xyz.kpxe netboot.xyz.lkrn netboot.xyz.pdsk netboot.xyz-snp.efi netboot.xyz-snponly.efi netboot.xyz-undionly.kpxe
where netboot.chicago.inthemainfra.me is the site_name. I think this PR is great as-is if the goal is to have valid links/references. could this get merged @antonym ?
thanks @antonym :-)