netboot.xyz icon indicating copy to clipboard operation
netboot.xyz copied to clipboard

Inconsistent use of bootloader_filename and site_name

Open abh opened this issue 3 years ago • 3 comments

The templates have a setting for bootloader_filename, but in most places site_name is used instead. This causes some features to break if site_name and bootloader_filename aren't set to the same thing.

For example the tftpmenu items aren't loaded and the URLs on the index.html page doesn't work.

abh avatar Mar 16 '22 00:03 abh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 15 '22 03:04 github-actions[bot]

Uh, not sure what's expected here. Bad bot?

abh avatar Apr 15 '22 05:04 abh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 16 '22 02:05 github-actions[bot]

No idea why this is inactive. It is a real issue.

oe3gwu avatar Mar 12 '23 09:03 oe3gwu

@oe3gwu I'm not using this actively anymore, but for my use it was fixed by #1096

abh avatar Mar 13 '23 01:03 abh

@abh I once looked at it, but actually wasnt aware that it was fixed. This issue should be closed then.

oe3gwu avatar Mar 13 '23 19:03 oe3gwu

@oe3gwu no, that change wasn't merged so it shouldn't be closed (but you can try the patch to see if it works for you).

abh avatar Mar 13 '23 19:03 abh