Change NETBIRD_SIGNAL_PORT mapping from 80 to 10000
This update aligns the template with the actual behavior of the Signal service and the official NetBird documentation.
Describe your changes
The advanced-setup docker-compose.yml template incorrectly mapped:
# Signal
signal:
....
ports:
- $NETBIRD_SIGNAL_PORT:80
However, the netbird-signal container listens on port 10000 internally.
This mismatch caused external Signal connections to fail unless users manually adjusted their NAT/firewall rules or remapped the port. The update changes the port mapping to:
# Signal
signal:
....
ports:
- $NETBIRD_SIGNAL_PORT:10000
This ensures correct behavior out of the box and makes the template consistent with the actual service configuration and official documentation.
Issue ticket number and link
N/A — Bug discovered during advanced setup deployment. (If an issue is later opened, it can be added here.)
Stack
Checklist
- [x] Is it a bug fix
- [ ] Is a typo/documentation fix
- [ ] Is a feature enhancement
- [ ] It is a refactor
- [ ] Created tests that fail without the change (if possible)
By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.
Documentation
Select exactly one:
- [ ] I added/updated documentation for this change
- [x] Documentation is not needed for this change (the fix corrects an incorrect port mapping in the docker template; no user-facing feature or behavior is changed, only the template is corrected to match the actual service port.)
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
N/A
Summary by CodeRabbit
-
Chores
- Updated Signal service port configuration in deployment setup.
✏️ Tip: You can customize this high-level summary in your review settings.
Walkthrough
The Signal service port mapping in the Docker Compose template is updated from host port 80 to port 10000. The container port is changed from 80 to 10000, and the environment variable $NETBIRD_SIGNAL_PORT now correctly maps to the updated container port.
Changes
| Cohort / File(s) | Change Summary |
|---|---|
Signal Service Port Configuration infrastructure_files/docker-compose.yml.tmpl |
Updated Signal service port mapping from $NETBIRD_SIGNAL_PORT:80 to $NETBIRD_SIGNAL_PORT:10000 |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related issues
- #4871: Addresses the incorrect docker-compose port mapping for the Signal service, aligning the host-to-container port forwarding configuration.
- #4762: Corrects the Signal service container port from 80 to 10000, matching the expected service port configuration.
Poem
🐰 A port tweak, so small yet keen, From eighty to ten-thousand, pristine! The Signal now hops to the right destination, Docker compose dances in configuration! 🎉
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and specifically summarizes the main change: updating the Signal service port mapping from 80 to 10000 in the docker-compose template. |
| Description check | ✅ Passed | The description includes all required template sections: detailed explanation of changes with code examples, issue reference, checklist completion, CLA acknowledgment, and documentation selection. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing touches
🧪 Generate unit tests (beta)
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
📜 Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between f538e6e9ae215d1e4baf48f93bbe6fbcb0f1e303 and 6b22c9b86190aad6a04074e0d49115a2d1c3c075.
📒 Files selected for processing (1)
-
infrastructure_files/docker-compose.yml.tmpl(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Agent
🔇 Additional comments (1)
infrastructure_files/docker-compose.yml.tmpl (1)
49-49: Verify Signal service port configuration before accepting this change.The review claims the Signal service listens on port 10000 internally, but this should be verified against the actual service configuration. Confirm:
- Signal service is configured to listen on port 10000, not port 80
- No other configuration files or documentation reference the old port 80 mapping for Signal
- Environment variable examples and defaults are consistent with this change
Unable to verify these claims against the codebase automatically. Manual verification is required to confirm this is a critical bug fix.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code