netbird icon indicating copy to clipboard operation
netbird copied to clipboard

Docker compose improvements

Open Silex opened this issue 7 months ago • 4 comments

Describe your changes

I can wrap my head around why management service would depend on dashboard, so here is a PR removing the dependency.

If the dependency is actually needed, I might transform this PR into one where I add HEALTHCHECK to the dashboard.

EDIT: ok the PR changed its goal toward general docker compose improvements.

Issue ticket number and link

Stack

Checklist

  • [ ] Is it a bug fix
  • [ ] Is a typo/documentation fix
  • [ ] Is a feature enhancement
  • [x] It is a refactor
  • [ ] Created tests that fail without the change (if possible)
  • [ ] Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Silex avatar Jun 16 '25 07:06 Silex

is mainly because we mount the certificates generated by the dashboard into the management

mlsmaycon avatar Jun 16 '25 07:06 mlsmaycon

@mlsmaycon ok thanks, I removed the commit. The rest should still apply, ask if you have questions.

Silex avatar Jun 16 '25 07:06 Silex

@mlsmaycon wait actually, why is it needed to mount the certificates generated by the dashboard into the management? is it if they both use the same domain on different ports?

I don't quite get it because by default it looks like only the dashboard serves HTTPS, and management is used internally on port 33080.

Or maybe it's simply so the letsencrypt folder contains all certificates, and the dependencies forces some kind of order for the file creation.

Silex avatar Jun 16 '25 11:06 Silex