netbird icon indicating copy to clipboard operation
netbird copied to clipboard

[client] Carry the peer's actual state with the notification.

Open pappz opened this issue 6 months ago • 1 comments

Describe your changes

This PR addresses an unnecessary invocation of GetStates in a separate thread during notification handling. The notifier now provides the relevant state data directly with each notification, eliminating the need for redundant or parallel state queries. This simplifies the logic, reduces potential race conditions.

Changes:

  • Removed separate thread execution of GetStates during notifications.
  • Updated notification handler to rely on state data included in the notification payload.

Issue ticket number and link

Stack

Checklist

  • [x] Is it a bug fix
  • [ ] Is a typo/documentation fix
  • [ ] Is a feature enhancement
  • [ ] It is a refactor
  • [ ] Created tests that fail without the change (if possible)
  • [ ] Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

pappz avatar Jun 05 '25 10:06 pappz