netbird icon indicating copy to clipboard operation
netbird copied to clipboard

Userspace implementation of RemoveAllowedIP recreates wireguard iface

Open hurricanehrndz opened this issue 9 months ago • 3 comments

Describe the problem

RemoveAllowedIP is not an update operation. Because of this when this function is called on platforms depending on the user space implementation of wireguard it results in all connections being dropped because it tries to use a port that is already in use.

To Reproduce

Steps to reproduce the behavior: Deselect one of the routes from the new "Network Routes" menu

Expected behavior

Expect removing an IP from peer ACL does not recreate wireguard interface

Are you using NetBird Cloud? NA

NetBird version

main

NetBird status -d output:

Not applicable

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

hurricanehrndz avatar May 02 '24 10:05 hurricanehrndz

@mlsmaycon latency base routing will not work without fixing this bug, because routes need to be successfully removed from allowed list without recreating wg iface

hurricanehrndz avatar May 02 '24 10:05 hurricanehrndz

I have a patch that fixes this

hurricanehrndz avatar May 02 '24 12:05 hurricanehrndz

Ok, thanks @hurricanehrndz we will review it soon after you open the PR.

mlsmaycon avatar May 02 '24 12:05 mlsmaycon