netbird icon indicating copy to clipboard operation
netbird copied to clipboard

Delete route from system only if added by the client

Open mlsmaycon opened this issue 1 year ago • 1 comments

This adds a flags to check if the addVPNRoute executed without issues before removing a route from the system

Describe your changes

Issue ticket number and link

Checklist

  • [ ] Is it a bug fix
  • [ ] Is a typo/documentation fix
  • [ ] Is a feature enhancement
  • [ ] It is a refactor
  • [ ] Created tests that fail without the change (if possible)
  • [ ] Extended the README / documentation, if necessary

mlsmaycon avatar Apr 12 '24 16:04 mlsmaycon

This is most likely superseded by changes in https://github.com/netbirdio/netbird/pull/1943, but needs tests

lixmal avatar May 21 '24 15:05 lixmal

This is most likely superseded by changes in #1943, but needs tests

Ok, let's close this one, as it would need a better approach anyway.

mlsmaycon avatar May 22 '24 16:05 mlsmaycon