react-native-color-wheel icon indicating copy to clipboard operation
react-native-color-wheel copied to clipboard

Merge 'Invariant Violation fix' to npm library

Open wongcoder opened this issue 6 years ago • 8 comments

Was working on React Native 0.59, imported your library, and realized that there was an invariant violation in ColorWheel.js.

It seems to be fixed on a later fix to master, but for some odd reason, NPM didn't pick up your changes.

This is a fantastic library, and I can't wait for the update.

wongcoder avatar May 09 '19 22:05 wongcoder

I don't think it was pushed to NPM, 0.1.7 is the latest tag and the update came after that. Facing the same issue, would love an update.

nsmet avatar May 10 '19 07:05 nsmet

Yup, same problem here. I would also love an update.

LapX avatar May 12 '19 04:05 LapX

Yeah, I basically just manually implemented the changes on my local machine, just gotta wait for the developers.

wongcoder avatar May 15 '19 19:05 wongcoder

@wongcoder What changes did you make?

@netbeast could you please provide update your package?

Thanks.

irajwani avatar Aug 14 '19 13:08 irajwani

@irajwani look at the code in the master branch and do the same modification. It worked for me. You must know where it crashes by looking at the error you got.

LapX avatar Aug 14 '19 19:08 LapX

Thank you @LapX, it worked! Fantastic library.

irajwani avatar Aug 14 '19 21:08 irajwani

update your package.json,

replace:

"react-native-color-wheel": "^0.1.7",

with:

"react-native-color-wheel": "https://github.com/netbeast/react-native-color-wheel.git",

That fixed it for me!

pastyman avatar Oct 08 '19 08:10 pastyman

Nice automated fix!

wongcoder avatar Oct 14 '19 18:10 wongcoder