nestjs-typeorm-paginate icon indicating copy to clipboard operation
nestjs-typeorm-paginate copied to clipboard

fix: add nestjs 9.0.0 to peer deps

Open jely2002 opened this issue 2 years ago • 7 comments

Fixes #749

This PR adds ^9.0.0 to the peer deps for @nestjs/common. So this package can be used with version 9. I have tested it quickly with a local project and it all appears to still work fine.

jely2002 avatar Jul 13 '22 13:07 jely2002

@bashleigh Could you perhaps review this? It would be awesome if we can update this package!

jely2002 avatar Jul 13 '22 13:07 jely2002

This is a blocker for my client for upgrading to Nest 9 as well! Can we get it reviewed soon?

martinsotirov avatar Jul 15 '22 07:07 martinsotirov

Great work. Would love to see this PR up!.

dalepo avatar Jul 21 '22 22:07 dalepo

This is also a blocker for me but I worked around it by simply using the PR version directly from @jely2002 . In your package.json change the entry to:

"nestjs-typeorm-paginate": "git+https://github.com/jely2002/nestjs-typeorm-paginate.git",

Simply change it back once this has been merged.

tfohlmeister avatar Jul 22 '22 08:07 tfohlmeister

Bump @bashleigh, any chance for this to be merged so we can use this package with NestJS 9?

jely2002 avatar Aug 03 '22 20:08 jely2002

This is also a blocker for me but I worked around it by simply using the PR version directly from @jely2002 . In your package.json change the entry to:

"nestjs-typeorm-paginate": "git+https://github.com/jely2002/nestjs-typeorm-paginate.git",

Simply change it back once this has been merged.

I'm getting EINTEGRITY errors this way in my Bitbucket CI Pipeline:

npm WARN tarball tarball data for nestjs-typeorm-paginate@git+ssh://[email protected]/jely2002/nestjs-typeorm-paginate.git#5749b85c006bc578438638fd446831d73fec7ccf (sha512-7rV+2UcaeSztHJFp5nXxJ/nax0GLUHFBO/TXW+oOVX+9YtUSaXknvDap33IENa151URCwgJh0jQ15RH9SLPIuw==) seems to be corrupted. Trying again.
npm ERR! code EINTEGRITY
npm ERR! sha512-7rV+2UcaeSztHJFp5nXxJ/nax0GLUHFBO/TXW+oOVX+9YtUSaXknvDap33IENa151URCwgJh0jQ15RH9SLPIuw== integrity checksum failed when using sha512: wanted sha512-7rV+2UcaeSztHJFp5nXxJ/nax0GLUHFBO/TXW+oOVX+9YtUSaXknvDap33IENa151URCwgJh0jQ15RH9SLPIuw== but got sha512-S0FMB6nxXHHbzV+hW6O8acG8cZZkayZocH8eCEWtorltowmzdeAn0Btyx36I2zX8DieZ4lVkaPqtd3sqalHktQ==. (10296 bytes)

martinsotirov avatar Aug 08 '22 10:08 martinsotirov

When are you merge for this PR. bacaue I use nestjs-typeorm-paginate for developer

DoIttikorn avatar Aug 08 '22 12:08 DoIttikorn