crud icon indicating copy to clipboard operation
crud copied to clipboard

TypeORM 0.3.0 support

Open andrewvasilchuk opened this issue 3 years ago • 13 comments

TypeORM 0.3.0 version was released. It would be great to add support for this version.

andrewvasilchuk avatar Jun 03 '22 13:06 andrewvasilchuk

My company is heavy user of this library, and since it's practically abandoned we decided to fork it. I've published today, alpha version with TypeORM 0.3x. support.

You can find the fork here : https://github.com/gid-oss/dataui-nestjs-crud , instructions how to use the 0.3.x version in the Readme.

Cheers.

zaro avatar Jun 17 '22 16:06 zaro

Very good, but I try to use your fork and there's an error on start compilation

Starting compilation in watch mode...

node_modules/@dataui/crud/lib/interfaces/auth-options.interface.d.ts:2:31 - error TS2307: Cannot find module 'crud-util/src' or its corresponding type declarations.

2 import { ObjectLiteral } from 'crud-util/src';

fscardua avatar Jun 24 '22 14:06 fscardua

There are some forks that support type orm >0.3.x out there. Most of them have some problems that make then not production ready. Is this something that is going to be implemented? or should we look somewhere else?

yepes avatar Jul 13 '22 09:07 yepes

@fscardua this is fixed in the latest alpha

zaro avatar Jul 13 '22 09:07 zaro

@zaro it would be great if you could review my PR and lmk if you have found any other issues. my PR passes all test for Postgres and MySQL on all ^0.3.X versions.

MrMaz avatar Jul 25 '22 18:07 MrMaz

@MrMaz I don't have any contributor rights for this repo and I belive it is abandoned. I try to maintain a fork here : https://github.com/gid-oss/dataui-nestjs-crud, and there is already some support for typeorm 0.3 in the alpha prereless version.

zaro avatar Jul 26 '22 04:07 zaro

@zaro i am in contact with the author, he had to flee Ukraine because of the war. i am going to inquire with him if there is any appetite to move this forward short term, or if it will be a while.

it would be great to compare notes with you on what TypeORM 0.3 issues you have needed to solve so far.

MrMaz avatar Jul 26 '22 12:07 MrMaz

@MrMaz good. Maybe you can sort it out, but the reality is the package was abandoned months before the war started, so I don't think the war has anything to do with that.

zaro avatar Jul 26 '22 14:07 zaro

@MrMaz any update?

gregsj avatar Aug 15 '22 22:08 gregsj

@zaro testing your fork with 0.3 and so far so good. Thanks

gregsj avatar Aug 16 '22 16:08 gregsj

my company also uses this library intensively.

I would appreciate any information when dataui-nestjs-crud will reach the release stage.

JensWunderwald avatar Sep 29 '22 15:09 JensWunderwald

@JensWunderwald it's in the bakclog, since we haven't moved to typeorm 0.3. So I made o ly preliminary testing and haven't released it yet because of lack of more testing ( only baic things have been tested so far) . But if it works for you this way I'm going to release it.

zaro avatar Sep 29 '22 15:09 zaro

There are safety issues.

Package Type Update Change
typeorm (source) dependencies minor ^0.2.42 -> ^0.3.0

Package Type Update Change typeorm (source) dependencies minor ^0.2.42 -> ^0.3.0 By merging this PR, the below vulnerabilities will be automatically resolved:

Severity CVSS Score CVE
High 9.8 CVE-2022-33171

jinpy666 avatar Oct 12 '22 06:10 jinpy666