crud fix(typeorm): correct quotes for column identifiers when driver is ‘mariadb‘

fix(typeorm): correct quotes for column identifiers when driver is ‘mariadb‘

Open constb opened this issue 4 years ago • 10 comments

#531 #545

TypeOrmCrudService.getFieldWithAlias escapes identifiers using backticks or double quotes.

it only uses backticks when this.dbName === 'mysql' but TypeORM also uses 'mariadb' to address a few subtle implementation differences.

this causes service to use double quotes in SQL and that fails with You have an error in your SQL syntax…

Jun 16 '20 07:06 constb

@adrianobnu personally I feel with only two comparisons the explicit code is better and more readable. but honestly whatever as long as a bug gets fixed, I'm fine with it… :)

Mar 04 '21 03:03 constb

@adrianobnu personally I feel with only two comparisons the explicit code is better and more readable. but honestly whatever as long as a bug gets fixed, I'm fine with it… :)

Yes, it works anyway, but this alternative only makes 1 comparison (instead of 2 or more if you have other databases in the same situation), and I see no difficulties in those who see the code understand what it does.

Mar 04 '21 12:03 adrianobnu

@zMotivat0r Can you do the review and approve the merge of this small fix?

Mar 04 '21 20:03 adrianobnu

Yes, it works anyway, but this alternative only makes 1 comparison (instead of 2 or more if you have other databases in the same situation), and I see no difficulties in those who see the code understand what it does.

@adrianobnu actually, Array.prototype.includes() must make 2 comparisons to make sure the item isn't in array, and an additional function call. :)

if you're thinking about doing micro-optimisations, I think regexp would be a couple nanoseconds faster here…

Mar 06 '21 13:03 constb

Having same error. This issue has been opened for 10 months now, it's a small fix, and it works fine for all MariaDB's users. Can we merge it? How can we help?

[Nest] 11360   - 2021-04-09 23:09:08   [ExceptionsHandler] You have an error in your SQL syntax;
check the manual that corresponds to your MariaDB server version for the right syntax to use near '."id" = 1)' at line 1 +30543ms