dyn-schematics icon indicating copy to clipboard operation
dyn-schematics copied to clipboard

Added missing imports property in module generation for registerAsync

Open benjbdev opened this issue 6 years ago • 3 comments

Hello,

At first thank you for your super package :)

I just made a small fix about the module generation, the "imports" property in the registerAsync methods was missing.

And so we couldn't load our module with a ConfigModule :

MyModule.registerAsync({
  imports: [ConfigModule],
  useFactory: async (configService: ConfigService) => ({
    url: configService.getString('URL')
  }),
  inject: [ConfigService],
}),

Thanks for reviewing.

benjbdev avatar Oct 22 '19 03:10 benjbdev

@benjaminb- Thank you for this! Unfortunately, I'm dealing with a family medical emergency and will be away for a couple of weeks. Just wanted to let you know I saw it and will get back to it when I get back.

johnbiundo avatar Oct 22 '19 19:10 johnbiundo

@johnbiundo Priority to family no worries :)

benjbdev avatar Oct 23 '19 00:10 benjbdev

Hi, any news on this PR ? I suppose it's abandonned in favor of NestJs CLI ? thanks :)

benjbdev avatar May 07 '20 06:05 benjbdev