typeorm icon indicating copy to clipboard operation
typeorm copied to clipboard

fix(provider): return proper repository

Open dineshsalunke opened this issue 2 years ago • 6 comments

check if the entity has tree metadata and return a tree repository if it exists

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Currently the providers don't return a TreeRepository for tree entities.

What is the new behavior?

Now the provider will create and return a tree repository for tree entities

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

dineshsalunke avatar Jul 10 '22 14:07 dineshsalunke

@kamilmysliwiec any update ?

dineshsalunke avatar Jul 11 '22 12:07 dineshsalunke

I am waiting this PR is merged

Kisama avatar Jul 12 '22 09:07 Kisama

@micalevisk @kamilmysliwiec any plans on merging this PR ?

dineshsalunke avatar Jul 16 '22 04:07 dineshsalunke

you can use patch-package until the merge

I don't have permissions to merge PRs

micalevisk avatar Jul 16 '22 15:07 micalevisk

@micalevisk we are already using patch-package for this, but that's not the ideal thing

dineshsalunke avatar Jul 16 '22 15:07 dineshsalunke

@kamilmysliwiec any idea if this can be merged or not ?

dineshsalunke avatar Jul 26 '22 03:07 dineshsalunke

LGTM

kamilmysliwiec avatar Aug 11 '22 07:08 kamilmysliwiec