throttler icon indicating copy to clipboard operation
throttler copied to clipboard
verified publisher icon nestjs

feat: Add setHeader option

Open gurgunday opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #2172

What is the new behavior?

Adds a setHeaders option to disable headers

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

gurgunday avatar Feb 07 '25 20:02 gurgunday

@jmcdo29 can you take a look? It would really help if this was merged as soon as possible :)

gurgunday avatar Feb 09 '25 11:02 gurgunday

@gurgunday why was PR abandoned?

oluizcarvalho avatar Aug 23 '25 05:08 oluizcarvalho

it got no response

gurgunday avatar Aug 23 '25 06:08 gurgunday

@jmcdo29 Can you please look at this one?

RomanDronow avatar Oct 28 '25 09:10 RomanDronow

The code here looks good. Apologies for the delay as my life has been chaotic this year and this stuff ends up slipping through the cracks. If you'd like to re-open the PR and add a changeset I'd be happy to merge it, or I can make my own branch for it.

@gurgunday

jmcdo29 avatar Oct 28 '25 14:10 jmcdo29

Sure thing, and no problem, it happens to the best of us

I can take a look at this tonight

gurgunday avatar Oct 29 '25 09:10 gurgunday