ng-universal icon indicating copy to clipboard operation
ng-universal copied to clipboard

chore(): updating nestjs peer dependencies to 9.0.0

Open quinnjr opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x ] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ x] Other... Please describe: Chore updating NestJS dependencies.

What is the current behavior?

NestJS dependencies do not allow for use with 9.x.x branches.

Issue Number: N/A

What is the new behavior?

Dependencies now allow use with 9.x.x branches.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ x] No

Other information

quinnjr avatar Sep 13 '22 01:09 quinnjr

@kamilmysliwiec Module could use some TLC

quinnjr avatar Sep 13 '22 01:09 quinnjr

Till this is merged and release I published a workaround package. You can drop it into the current installation without changing imports by adding "@nestjs/ng-universal": "npm:@nestjs-fixed/[email protected]", to your package.json.

DaSchTour avatar Sep 16 '22 12:09 DaSchTour

@kamilmysliwiec still in need of a merge

quinnjr avatar Nov 17 '22 21:11 quinnjr

@DaSchTour can you add ticket creation to your fork?

quinnjr avatar Nov 18 '22 16:11 quinnjr

@quinnjr you mean the issues tab? That's done

DaSchTour avatar Nov 18 '22 16:11 DaSchTour

Fixed in this PR https://github.com/nestjs/ng-universal/pull/943

kamilmysliwiec avatar Feb 09 '23 10:02 kamilmysliwiec