nest icon indicating copy to clipboard operation
nest copied to clipboard
verified publisher icon nestjs

ci(): use next-gen convenience image

Open wodCZ opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

The build page at circleci displays the following notice:

You’re using a deprecated Docker convenience image. Upgrade to a next-gen Docker convenience image.

Following the article we can see that the current images are no longer supported and no updates will be published.

Dec 31, 2021 - Legacy Convenience Images are no longer supported. This will be the last publishing day of these images. Existing tags will still exist on Docker Hub but will remain unchanged. There will be no support for bug or security fixes for existing tags. No new tags will be published after this day.

Issue Number: N/A

What is the new behavior?

The recommended convenience images are used and the deprecation warning is no longer displayed.

The previous image was pinned on Node.js v16.*. The new images don't support major-only version pinning and require an explicit minor version, 16.15 as of now (see github repo).

I couldn't find a list of changes between circleci/node and cimg/node, the only reference I found says it's a direct replacement.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

wodCZ avatar Jul 17 '22 13:07 wodCZ

Pull Request Test Coverage Report for Build 943b5ead-54c4-49dd-b800-49bf4aa533e8

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.089%
Totals Coverage Status
Change from base Build b4e83393-2c41-41a0-8953-6cdb15ff24c1: 0.0%
Covered Lines: 6049
Relevant Lines: 6429
💛 - Coveralls

coveralls avatar Jul 17 '22 13:07 coveralls

https://github.com/nestjs/nest/pull/11434

kamilmysliwiec avatar Apr 06 '23 07:04 kamilmysliwiec