nest icon indicating copy to clipboard operation
nest copied to clipboard

feat(core, common): add webdav http methods support

Open hungtcs opened this issue 3 years ago • 1 comments

Closes #9459

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #9459

What is the new behavior?

Add new decorators for webdav methods, like @PropFind

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

hungtcs avatar Apr 14 '22 09:04 hungtcs

Pull Request Test Coverage Report for Build fe8aaca5-cb3a-4736-b297-eaba6ec6d663

  • 19 of 26 (73.08%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 93.955%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/helpers/router-method-factory.ts 0 7 0.0%
<!-- Total: 19 26
Totals Coverage Status
Change from base Build 5cf0e473-a21f-4756-8d9d-72a40ee32710: -0.09%
Covered Lines: 5782
Relevant Lines: 6154

💛 - Coveralls

coveralls avatar Apr 14 '22 09:04 coveralls

The support of fastify is merged already https://github.com/fastify/fastify/pull/3836. We love to see this shipped!

Nisgrak avatar Sep 07 '22 09:09 Nisgrak

Any news on this ? Aborted ?

johaven avatar Nov 22 '23 23:11 johaven

image

jmcdo29 avatar Nov 22 '23 23:11 jmcdo29

Yes I saw :p Is an implementation of these decorators planned on your side ?

johaven avatar Nov 22 '23 23:11 johaven