nest icon indicating copy to clipboard operation
nest copied to clipboard

Update package.json

Open ragavendra opened this issue 8 months ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce? e2e test app.e2e-spec.ts has chai dependency which was not available in package,json.

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x ] Other... Please describe: Added chai to dev dependencies. Using 4.3.9 for chai as the latest version gives import error for expect.

What is the current behavior?

npm run test:e2e fails when running test in app.e2e-spec.ts on import { expect } from "chai"

Issue Number: N/A

What is the new behavior?

npm run test:e2e now passes.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ x] No

Other information

ragavendra avatar Jun 14 '24 01:06 ragavendra