nest refactor(microservices): improve speed of grpc server initialization

refactor(microservices): improve speed of grpc server initialization

Open yjiq150 opened this issue 10 months ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

In order to find grpc service descriptors, collectDeepServices function recursively searches whole grpcDefinitions generated by protoLoader, which currently includes all descriptors like namespace, service, and field.

What is the new behavior?

Because field descriptors cannot have namespace as their child, they don't need to be recursively searched. They can distinguished by checking existence of 'format' field and they can be skipped from the search to speed up the process.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

In the project I am working on, proto models are heavily used. It took more than 3 seconds in M2 MacBook Pro to run collectDeepServices before the modification. Now it takes around 300ms in the same environment after the modification