nest icon indicating copy to clipboard operation
nest copied to clipboard

test(sample-12): added unit and e2e tests

Open pacyL2K19 opened this issue 1 year ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other: Added unit and e2e tests to the sample-12

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

I have added unit and e2e tests to the sample-12-graphql-schema-first Increased the test coverage This is my first contribution to the project, I may miss a couple of things, I will appreciate any feedback

pacyL2K19 avatar Nov 23 '23 00:11 pacyL2K19

Pull Request Test Coverage Report for Build 80567a20-17a5-4037-8fd1-f2a66e07e4f6

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.258%

Totals Coverage Status
Change from base Build 07271e8a-a67e-47df-be5c-241b54a18b75: 0.0%
Covered Lines: 6697
Relevant Lines: 7259

💛 - Coveralls

coveralls avatar Nov 23 '23 00:11 coveralls

@micalevisk fixed the conflicts by rebasing with nest:master, please have a look

pacyL2K19 avatar Nov 25 '23 17:11 pacyL2K19