nest icon indicating copy to clipboard operation
nest copied to clipboard

fix(core): root path middleware not applied when setting the global prefix

Open CodyTseng opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #11572

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

CodyTseng avatar Aug 01 '23 13:08 CodyTseng

Pull Request Test Coverage Report for Build 8835fc59-fe00-45a0-886e-1cbcd9a0dccb

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.161%

Totals Coverage Status
Change from base Build 2bf2e4c8-5da9-4dd1-8f93-3b733029afc6: 0.001%
Covered Lines: 6737
Relevant Lines: 7310

💛 - Coveralls

coveralls avatar Aug 01 '23 13:08 coveralls

I created a new PR based off this one with a slightly different approach in order to avoid introducing breaking changes Let's track this here https://github.com/nestjs/nest/pull/13337

kamilmysliwiec avatar Mar 18 '24 10:03 kamilmysliwiec