nest icon indicating copy to clipboard operation
nest copied to clipboard

Published 20 hours ago • verified publisher icon nestjs

feat(common): support to serialize plain object

Open zanminkian opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #10086

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

zanminkian avatar Aug 09 '22 12:08 zanminkian

Pull Request Test Coverage Report for Build af1c6764-b52c-40cb-9a00-21164947e7e2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.826%
Totals Coverage Status
Change from base Build 7429007a-3efb-492d-a2a1-84f706a41b5f: 0.0%
Covered Lines: 6094
Relevant Lines: 6495
💛 - Coveralls

coveralls avatar Aug 09 '22 12:08 coveralls

If this feature is reasonable, I will add docs and unit test later. Any suggestion please let me know.

zanminkian avatar Aug 09 '22 14:08 zanminkian

I agree with @micalevisk suggestion here https://github.com/nestjs/nest/issues/10086#issuecomment-1209349988

kamilmysliwiec avatar Aug 11 '22 07:08 kamilmysliwiec

lgtm

kamilmysliwiec avatar Sep 19 '22 12:09 kamilmysliwiec