nest-cli icon indicating copy to clipboard operation
nest-cli copied to clipboard

fix(cli) support packageManager schematics option

Open kesslerdev opened this issue 5 years ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

when create a new application the cli doesn't prompt for package manager before generating files and also doesn't send the right option to schematics

Issue Number: https://github.com/nestjs/schematics/issues/249

What is the new behavior?

the cli prompt for package manager before generating files and send the correct option packageManager

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

kesslerdev avatar Dec 15 '19 23:12 kesslerdev

the build script seems broken :/

kesslerdev avatar Dec 18 '19 13:12 kesslerdev

related issue (build failure) https://github.com/zkat/npx/issues/100

kesslerdev avatar Dec 19 '19 13:12 kesslerdev

Can you rebase your PR? We switched to CircleCI + different configuration, errors should be gone

kamilmysliwiec avatar Dec 21 '19 10:12 kamilmysliwiec

branch is rebased

kesslerdev avatar Dec 23 '19 07:12 kesslerdev

I just tried your fork @kesslerdev well done! Can you please rebase it again?

micalevisk avatar Sep 24 '21 01:09 micalevisk