nest-cli icon indicating copy to clipboard operation
nest-cli copied to clipboard

refactor: use `fs/promises` instead of `rimraf` package

Open Phillip9587 opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

refactor to use the rm() method instead of the rimraf package. Also moved the deleteOutDirIfEnabled() method from the WorkspaceUtils class into its own file inside the helper directory because it is the only method of the class.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Phillip9587 avatar Feb 24 '24 17:02 Phillip9587

@micalevisk Any chance this is getting merged?

Phillip9587 avatar May 10 '24 11:05 Phillip9587

LGTM

kamilmysliwiec avatar Jul 02 '24 06:07 kamilmysliwiec