mongoose icon indicating copy to clipboard operation
mongoose copied to clipboard

Feature: virtual decorator

Open LotfiMEZIANI opened this issue 2 years ago • 8 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #1349

What is the new behavior?

Described here : #1349

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

LotfiMEZIANI avatar May 18 '22 14:05 LotfiMEZIANI

Can you add tests?

kamilmysliwiec avatar May 19 '22 08:05 kamilmysliwiec

@kamilmysliwiec

Can you add tests?

It's done. But i don't know if I done it in the correct folder (tests/e2e).

LotfiMEZIANI avatar May 22 '22 18:05 LotfiMEZIANI

Would love to see this get merged.

hartherbert avatar Jun 06 '22 06:06 hartherbert

Any updates here?

bytesbay avatar Aug 31 '22 18:08 bytesbay

@kamilmysliwiec, waiting for the merge, if everything is ok.

LotfiMEZIANI avatar Sep 01 '22 18:09 LotfiMEZIANI

@LotfiMEZIANI @kamilmysliwiec Any news on this? this should have merged by now...

KevinEdry avatar Feb 12 '23 13:02 KevinEdry

@KevinEdry, for me it’s fine, I’m waiting for the validation of an owner of the repository (ping @kamilmysliwiec )

LotfiMEZIANI avatar Feb 15 '23 15:02 LotfiMEZIANI

bump

I just happen to need this.

graddaniel avatar Jan 10 '24 11:01 graddaniel