jwt icon indicating copy to clipboard operation
jwt copied to clipboard
verified publisher icon nestjs

fix: dont omit signoptions in sign and signasync

Open aayushchugh opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #1369 fixes #1369

What is the new behavior?

  1. Removed Omit type from sign and signAsync
  2. Failing tests are now passing
  3. Removed unused @ts-expect-error
  4. Allowed string type as parameter in sign and signAsync types

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

image

aayushchugh avatar Jul 17 '23 09:07 aayushchugh

cc @Hender-hs

kamilmysliwiec avatar Jul 17 '23 11:07 kamilmysliwiec

@kamilmysliwiec Any update on this PR?

aayushchugh avatar Dec 07 '23 13:12 aayushchugh

Closing this PR

aayushchugh avatar Jun 02 '24 15:06 aayushchugh