docs.nestjs.com icon indicating copy to clipboard operation
docs.nestjs.com copied to clipboard

docs(microservices): Update ip address:port for a gRPC Docker server

Open youngkiu opened this issue 11 months ago • 0 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/docs.nestjs.com/blob/master/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Docs
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Actually https://github.com/youngkiu/nest/blob/7f00840c074ba5a5f233f73ef6c8456115abd7c1/packages/microservices/constants.ts#L11, I wanted to suggest modifying GRPC_DEFAULT_URL, Since it was clearly stated as Default in the document, I thought there was an intention to do this.

So, I suggest modifying the example in the document. In the case of servers, it is often built and used as a docker image. 0.0.0.0:50051 seems more appropriate as an example than localhost:50051.

In particular, in the case of gRPC in the target group of the AWS load balancer, since the success code of the health check is 12(UNIMPLEMENTED), I hope that if the example is 0.0.0.0:50051 it will further reduce confusion.

youngkiu avatar Mar 01 '24 09:03 youngkiu